Skip to content

Commit

Permalink
Paint view background in contents space if <html> has effects or clip…
Browse files Browse the repository at this point in the history
…-path

If the document element has effects or clip-path, we should paint
the view background with the view's contents transform and the root
element's clips and effects. However, previously if the view
background had fixed attachment, we might paint the background in
the border box space, which broke the above logic. Now always
paint view background in the contents space if the document
element has effects or clip-path.

Bug: 397737220
Change-Id: I1acef9cacc23711d2f9cfe4377c14056e91ddd3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6324752
Commit-Queue: Xianzhu Wang <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1428509}
  • Loading branch information
wangxianzhu authored and chromium-wpt-export-bot committed Mar 5, 2025
1 parent acb6cbf commit a9f4eee
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<meta name="assert" content="The background image should have opacity applied to
it as part of the Root Element Group">
<link rel="match" href="root-element-background-image-transparency-001-ref.html">
<meta name="fuzzy" content="maxDifference=0-1; totalPixels=0-9600" />
<meta name="fuzzy" content="maxDifference=0-1; totalPixels=0-250000" />
<style>
html {
background: url(support/transform-triangle-left.svg) fixed;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<meta name="assert" content="The background image should have opacity applied to
it as part of the Root Element Group">
<link rel="match" href="root-element-background-image-transparency-001-ref.html">
<meta name="fuzzy" content="maxDifference=0-1; totalPixels=0-237600" />
<meta name="fuzzy" content="maxDifference=0-1; totalPixels=0-250000" />
<style>
html {
background: url(support/transform-triangle-left.svg) fixed;
Expand Down

0 comments on commit a9f4eee

Please sign in to comment.