fix: perf regression caused by is_deferred #11944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
release: bug fix
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a performance regression by caching the has_imported_by_defer flag in the module's build metadata instead of iterating through incoming connections on every call to is_deferred. The optimization moves the computation from query-time to build-time.
- Adds a new
has_imported_by_deferfield toBuildMetato cache deferred import status - Updates
is_deferredmethod to use the cached flag instead of iterating connections - Computes and sets the flag during module graph updates in the
AddTask
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/rspack_core/src/module_graph/mod.rs | Simplifies is_deferred to use cached flag and removes DependencyType import |
| crates/rspack_core/src/module.rs | Adds has_imported_by_defer field to BuildMeta struct |
| crates/rspack_core/src/compilation/make/graph_updater/repair/add.rs | Computes and sets has_imported_by_defer during module resolution |
| crates/rspack_binding_api/src/module.rs | Updates JS binding to include new has_imported_by_defer field |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
crates/rspack_core/src/compilation/make/graph_updater/repair/add.rs
Outdated
Show resolved
Hide resolved
crates/rspack_core/src/compilation/make/graph_updater/repair/add.rs
Outdated
Show resolved
Hide resolved
|
📝 Benchmark detail: Open
|
JSerFeng
previously approved these changes
Oct 21, 2025
📦 Binary Size-limit
❌ Size increased by 1.75KB from 47.73MB to 47.73MB (⬆️0.00%) |
CodSpeed Performance ReportMerging #11944 will not alter performanceComparing Summary
|
hardfist
reviewed
Oct 21, 2025
ahabhgk
force-pushed
the
fix-perf-is-deferred
branch
from
32c5209 to
9be15f2
Compare
|
📝 Benchmark detail: Open
|
SyMind
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We can record the
has_imported_by_deferat make, and avoid iterate on incoming connectionsRelated links
Checklist