Skip to content

Conversation

2heal1
Copy link
Member

@2heal1 2heal1 commented Oct 11, 2025

Summary

Ship MF manifest to rust, aims to speed up the build time which will be much slower in stats.toJson() in js side .

MF manifest is an important feature in MFV2 , it provides enough context to allow framework to extend features, like SSR/RSC/Server Preload.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Oct 11, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit cd9609d
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68f630d6df9e6e0008872ffa

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Oct 11, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 11, 2025

CodSpeed Performance Report

Merging #11846 will not alter performance

Comparing 2heal1:feat/manifest-builtin (cd9609d) with main (cf64d74)

Summary

✅ 17 untouched

@2heal1 2heal1 force-pushed the feat/manifest-builtin branch 3 times, most recently from 6a2dd1c to 92e9f3e Compare October 16, 2025 12:12
@2heal1 2heal1 marked this pull request as ready for review October 16, 2025 12:34
@2heal1 2heal1 force-pushed the feat/manifest-builtin branch 2 times, most recently from 1dad2f7 to 25278e4 Compare October 17, 2025 14:19
@2heal1 2heal1 force-pushed the feat/manifest-builtin branch from 25278e4 to 74c6c8c Compare October 20, 2025 02:32
enhanced: true
}).apply(compiler);

if (this._options.manifest !== false) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean now user that uses rspack.container.ModuleFederationPlugin will also have a manifest by default? If yes then this should change to disabled by default, we should not give surprise to user, but this can be part of Rspack v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature release: feature related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants