fix(core): output.assetsInclude adds a rule but not exposes public api
#4385
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SoonIter
changed the title
output.assetsInclude add a rule but not export public apioutput.assetsInclude adds a rule but not exposes public api
chenjiahan
reviewed
Jan 17, 2025
| @@ -99,6 +99,8 @@ export const CHAIN_ID = { | |||
| IMAGE: 'image', | |||
| /** Rule for media */ | |||
| MEDIA: 'media', | |||
| /** Rule for additional asset */ | |||
| ADDITIONAL: 'additional', | |||
There was a problem hiding this comment.
Why not use additional-assets here
There was a problem hiding this comment.
is additional-asets-asset-url acceptable?
There was a problem hiding this comment.
But additional-assets-asset-url is not a Rule name.
chenjiahan
reviewed
Jan 17, 2025
| @@ -131,7 +131,7 @@ export const pluginAsset = (): RsbuildPlugin => ({ | |||
| const { assetsInclude } = config.source; | |||
| if (assetsInclude) { | |||
| const { dataUriLimit } = config.output; | |||
| const rule = chain.module.rule('additional-assets').test(assetsInclude); | |||
| const rule = chain.module.rule('additional').test(assetsInclude); | |||
There was a problem hiding this comment.
same as above,
font, image does not use CHAIN_ID
CHAIN_ID only for public api now
There was a problem hiding this comment.
If we are not using CHAIN_ID here, why does this PR need to update the CHIND_ID constant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
not regular
should be
${type}-asset-urlRelated Links
for Rslib Asset
web-infra-dev/rslib#684
Checklist