Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asset-retry): avoid using function rest parameters #4313

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Jan 1, 2025

Summary

Avoid using function rest parameters, use arguments instead.

Reasons:

  • Reduce the generated ES5 code, asyncChunkRetry.min.js from 4,582 bytes -> 4,389 bytes
  • This allows us to use SWC instead of Babel to transform the code. If we use rest parameters, the SWC helpers will introduce Array.from, which is an ES6 API. See perf(asets-retry): use SWC to transform and minify code #4312.
  • The code looks nicer.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jan 1, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit ace2d5f
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/677544d84770bb0008bd31e6
😎 Deploy Preview https://deploy-preview-4313--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan requested a review from SoonIter January 2, 2025 02:13
@SoonIter SoonIter enabled auto-merge (squash) January 2, 2025 03:31
@SoonIter SoonIter merged commit b826a24 into main Jan 2, 2025
9 checks passed
@SoonIter SoonIter deleted the rest_parameters_0101 branch January 2, 2025 03:32
@SoonIter
Copy link
Member

SoonIter commented Jan 2, 2025

LGTM~

@chenjiahan chenjiahan mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants