Improve self-referential error message to include offending namespace #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. Can you ensure the commit adheres to the contributing guidelines. |
spariev
force-pushed
the
improved-error-message
branch
2 times, most recently
from
50c7c49 to
cbb19e0
Compare
|
I've reformatted the commit message a bit, other than that it all looks fine to me |
weavejester
reviewed
Feb 13, 2020
Error message includes the name of the offending namespace now. This way it is much easier to find and fix the error.
spariev
force-pushed
the
improved-error-message
branch
from
cbb19e0 to
b4b06fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way it is much easier to fix such an errors in a large codebase