Track a namespace's dependencies on non-Clojure files #24
Conversation
Uses patched ns-tracker, weavejester/ns-tracker#24
Uses patched ns-tracker, weavejester/ns-tracker#24
|
That should be all the discussed changes covered. The readme still needs to be updated. I'll do it later today. |
|
That's all that comes to my mind. Do you have any more feedback? I've published this version also as |
|
Is that all? |
|
Thanks, that looks all fine. Can you wrap the source code at 80 characters, and the README at 72 characters? |
|
I'm afraid your code reformat makes it really quite hard to see what's changed, as you've altered a lot of lines that have nothing to do with the PR. I realize the codebase is old, but can you limit your changes to the code that has been altered, and we can save a global format for another PR? |
luontola
force-pushed
the
resource-deps
branch
from
d8d4d3b to
61ff0db
Compare
|
👌 |
|
The full reformat is in branch https://github.com/luontola/ns-tracker/tree/code-reformat |
|
Thanks, this looks great. Can you squash your commits down? Once there's a clean history I think we can merge. |
luontola
force-pushed
the
resource-deps
branch
from
61ff0db to
df2e6cd
Compare
|
Squashed. One commit with the feature and another for global code reformat. |
|
Sorry for the delay in getting around to reviewing this. Everything looks okay. Can you change the commit messages to follow these seven rules, and then it should be good to merge. |
luontola
force-pushed
the
resource-deps
branch
from
df2e6cd to
6c317b8
Compare
Some libraries such as HugSQL define functions in a namespace based on the contents of a static resource file. When that file is changed, the namespace needs to be reloaded to reflect the changes. This change adds support for a :ns-tracker/resource-deps metadata in the namespace declaration for listing the resources that the namespace depends on, to facilitate reloading the namespace when one of the resources changes. Resolves: weavejester#23
luontola
force-pushed
the
resource-deps
branch
from
6c317b8 to
24d7513
Compare
|
Commit messages changed. 👌 |
|
Since there is not yet a new release of ns-tracker, I've published an unofficial build of the current master branch: |
This PR implements issue #23.
If you add
:resource-depsmetadata to a namespace declaration and list there all the static resources which the namespace depends on, then that namespace will be reloaded whenever one of those resources is changed.An example usage with Luminus conman would look like this:
Additionally Ring's
wrap-reloadmay need to be configured to find the resources directory:This PR is also available as a published binary; add the following dependency and exclude the original ns-tracker.