Update to Lucene 4.10.4 #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Please see the discussion in #23. Rather than developing this further, James would rather move work to a fork and promote that, but I don't believe there's any consensus yet about which fork. |
|
Yeah I mailed James earlier this afternoon to ask about this. I think I'm just gonna run with this as suits my needs and there was some noise about becomming the canonical version if it stays active. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Lucene API changed so that
IndexWriter.deleteDocumentsbecame variadic. This is a non-issue for Java code since javac will upgrade transparently, but requires some reflection and array work from us. This patch makes the appropriate reflection changes to support the latest 4.X and bumps the patch number.Porting to 5.X looks like it will be nontrivial.