Skip to content

Prevent installation of MagicPython on ST4 #8841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Conversation

FichteFoll
Copy link
Collaborator

There is very little reason to do this when the default syntax definition is much better due to using the sublime-syntax format, follows the scope naming standards and is actively maintained, because this package hasn't had a tag pushed in 4 years despite seeing some changes, albeit the last one over a year ago.

A pull request asking for clarification of the support status for ST4 has not been answered for 8 months.
MagicStack/MagicPython#255

cc @vpetrovykh (FYI)

There is very little reason to do this when the default syntax
definition is much better due to using the `sublime-syntax` format,
follows the scope naming standards and is actively maintained, because
this package hasn't had a tag pushed in 4 years despite seeing *some*
changes, albeit the last one over a year ago.

A pull request asking for clarification of the support status for ST4
has not been answered for 8 months.
MagicStack/MagicPython#255
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - MagicPython

@braver
Copy link
Collaborator

braver commented Nov 19, 2023

There's been plenty of time to respond. Sometimes this is just the way packages go. Especially for syntaxes, the default packages are really hard to compete with in recent years (it has been otherwise!).

LGTM

@braver braver merged commit 37cc786 into master Nov 19, 2023
@braver braver deleted the pr/no-magicpython-on-st4 branch November 19, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants