Skip to content

Conversation

@waynehamadi
Copy link
Owner

Background

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run black . and isort . against my code to ensure it passes our linter.

BaseInfinity and others added 4 commits May 26, 2023 11:07
…ending on module

fix: formatting for linter

test: commit newly generated cassettes to their respective folder

tests: update latest fixtures with master

fix: update .gitattributes with updated path to cassettes

fix: use cassettes from master instead of generating them myself

fix: update path in .gitattributes

fix: make sure to match default functionality by using test name for cassette directory

fix: actually add git submodule

ci: checkout git submodules in CI

ci: update git submodules separately to ensure it gets called

feat: add a hooks directory so we can update git submodules on post-checkout

feat: make sure we push the tests/cassettes submodule on merge into master

ci: remove unused code now that we are using git submodules to keep cassettes in sync

fix: simplify how we load the submodule and fix updating cassettes on merge to master

chore: remove echo of checkout hook, it's unneeded

ci: remove unneccesary step
@github-actions
Copy link

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions
Copy link

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@waynehamadi waynehamadi force-pushed the master branch 2 times, most recently from bc9523d to 28b01bc Compare May 28, 2023 01:17
@github-actions
Copy link

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@waynehamadi waynehamadi force-pushed the master branch 4 times, most recently from f1765eb to 9e9b128 Compare May 31, 2023 00:32
@waynehamadi waynehamadi force-pushed the master branch 10 times, most recently from fc642b6 to bc5dbb6 Compare June 11, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants