Fix/glm4 add validation tests from b2ornot2b#440
Merged
Thump604 merged 2 commits intowaybarrios:mainfrom Apr 29, 2026
Merged
Conversation
janhilgard
approved these changes
Apr 29, 2026
Collaborator
janhilgard
left a comment
janhilgard
left a comment
There was a problem hiding this comment.
Clean test additions from b2ornot2b's PR #246. Good coverage for GLM4 reasoning parser registration and GLM47 tool parser — especially the zero-argument edge case which is a common failure mode.
CI 9/9 pass. Minor: 2 commits could be squashed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge glm4 tests from b2ornot2b from PR #246.