Skip to content

WIP: replace register-alloc with purely stack-based translation #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 77 commits into
base: main
Choose a base branch
from

Conversation

Robbepop
Copy link
Member

Closes #1484.

@Robbepop Robbepop changed the title Replace register-alloc with purely stack-based translation WIP: replace register-alloc with purely stack-based translation May 10, 2025
Copy link

codecov bot commented May 10, 2025

Codecov Report

Attention: Patch coverage is 3.87289% with 968 lines in your changes missing coverage. Please review.

Project coverage is 66.87%. Comparing base (d63125c) to head (e4dd0e0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...mi/src/engine/translator/translator2/simd/visit.rs 0.00% 256 Missing ⚠️
...s/wasmi/src/engine/translator/translator2/visit.rs 0.00% 213 Missing ⚠️
...src/engine/translator/translator2/stack/control.rs 0.00% 115 Missing ⚠️
...rc/engine/translator/translator2/stack/operands.rs 0.00% 115 Missing ⚠️
...smi/src/engine/translator/translator2/stack/mod.rs 0.00% 87 Missing ⚠️
...src/engine/translator/translator2/stack/operand.rs 0.00% 46 Missing ⚠️
...tes/wasmi/src/engine/translator/translator2/mod.rs 0.00% 42 Missing ⚠️
...mi/src/engine/translator/translator2/layout/mod.rs 0.00% 35 Missing ⚠️
...src/engine/translator/translator2/layout/consts.rs 0.00% 32 Missing ⚠️
.../src/engine/translator/translator2/stack/locals.rs 72.22% 15 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1512      +/-   ##
==========================================
- Coverage   70.69%   66.87%   -3.83%     
==========================================
  Files         177      188      +11     
  Lines       16585    17592    +1007     
==========================================
+ Hits        11725    11764      +39     
- Misses       4860     5828     +968     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Robbepop Robbepop force-pushed the rf-stack-based-translation branch from 3d12a1f to 01dceaa Compare May 11, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wasmi translator: replace register alloc with stack walker
1 participant