Skip to content

Conversation

@marxin
Copy link
Contributor

@marxin marxin commented Nov 28, 2025

Depot does not provide macOS Intel runners, and so let's demote them as something we'll be testing only on main branch (or a release branch).

Copilot AI review requested due to automatic review settings November 28, 2025 08:53
Copilot finished reviewing on behalf of marxin November 28, 2025 08:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes CI costs by configuring the macos-15-intel runner (macos-x64) to skip execution in pull requests and only run on the main branch or release branches. This is achieved by adding a run_in_pr flag to each build metadata configuration and implementing a conditional check at the job level.

Key changes:

  • Added run_in_pr boolean field to all metadata entries in the build job matrix
  • Set run_in_pr: false for macos-x64 (macos-15-intel) to skip it in PRs
  • Set run_in_pr: true for all other platforms (linux-x64, macos-arm, windows-x64, windows-gnu, linux-musl)
  • Added job-level conditional to respect the run_in_pr flag and run all builds on non-PR events

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@marxin marxin requested a review from Copilot November 28, 2025 09:00
Copilot finished reviewing on behalf of marxin November 28, 2025 09:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@marxin marxin marked this pull request as draft November 28, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants