Skip to content

Conversation

@marxin
Copy link
Contributor

@marxin marxin commented Nov 26, 2025

Based on the discussion with @theduke, the sccache tends to be really slow and was disabled some time ago. The other changes are related to GH workflow issues reported in the VSCode.

Copilot AI review requested due to automatic review settings November 26, 2025 12:20
Copilot finished reviewing on behalf of marxin November 26, 2025 12:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unused sccache caching infrastructure and fixes GitHub Actions workflow issues flagged by VSCode. The changes clean up workflow files by removing:

  • sccache-related build matrix parameters, installation steps, and configuration
  • unused target parameters from rust-toolchain actions in jobs that don't need them
  • unnecessary container configuration
  • cosmetic fixes to commented-out code

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/build.yml Removed all sccache-related configuration including use_sccache/use_rustcache matrix parameters, sccache installation steps, cache actions, port configuration, and unused container specification
.github/workflows/test.yaml Removed unused target parameter from rust-toolchain action in test_integration_cli job and cleaned up commented-out WASMER_PATH exports
.github/workflows/cloudcompiler.yaml Removed unused target parameter from rust-toolchain action in the setup job

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants