feat: Add SuggestedCompilerOptimization type(s) to automatically infer when to enable g0m0 optimization
#5518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 22, 2025 15:45
…, use current opts as part of the ID
|
📝 Documentation updates detected! A separate PR for documentation updates has been made here: wasmerio/docs.wasmer.io#127 |
syrusakbary
reviewed
Apr 22, 2025
lib/types/src/target.rs
Outdated
| // Note: This type is a copy of `wasmer_config::package::SuggestedCompilerOptimizations`, so to | ||
| // avoid dependencies on `wasmer_config` for crates that already depend on `wasmer_types`. | ||
| #[derive(Clone, Debug, PartialEq, Eq, Default)] | ||
| pub struct SuggestedCompilerOptimizations { |
Member
There was a problem hiding this comment.
Suggested change
| pub struct SuggestedCompilerOptimizations { | |
| pub struct UserCompilerOptimizations { |
syrusakbary
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title. This PR introduces two (equally-shaped) types in
wasmer_config(to refer to the annotation observed from a Wasmer manifest) and inwasmer_types::target(for the actual types to pass to engines) that represent annotations from users, which can be used to specify suggested compiler optimizations. For example:This PR also adds the code necessary to serialize and deserialize this metadata in the manifest (and keep it in the related webc).