CLI: package unpack command improvements #5454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the output path is not manually specified, the command will fail if the /tmp path is on a separate partition, because the tmpfile can't be renamed. This fixes things by always persisting the tmpfile in the target directory.
|
📝 Documentation updates detected! A separate PR for documentation updates has been made here: wasmerio/docs.wasmer.io#120 |
theduke
force-pushed
the
run-607-cli-package-unpack-improve-tmpfile-behaviour-and-add-unpack
branch
from
ac2031f to
94726f9
Compare
xdoardo
approved these changes
Mar 6, 2025
xdoardo
deleted the
run-607-cli-package-unpack-improve-tmpfile-behaviour-and-add-unpack
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(cli): Improve 'package download' command behaviour
Improves tempory file handling when no manual output path is specified.
The command was broken when /tmp is located on a separate partition.
feat(cli): Add --unpack flag to the 'package download' command
Closes #5453