JS ES6 Support and Template Literals Support #1493
Conversation
| } | ||
|
|
||
| @Override | ||
| public CAstNode visitTemplateLiteral(TemplateLiteral node, WalkContext arg) { |
There was a problem hiding this comment.
I can't really understand the logic here; I think we need some comments to explain. Is the code in this method handling just the string concatenation?
| public CAstNode visitTaggedTemplateLiteral(TaggedTemplateLiteral node, WalkContext arg) { | ||
| // TODO Auto-generated method stub | ||
| return null; | ||
| } |
There was a problem hiding this comment.
I'm concerned this will cause a crash if we get an input with a tagged template literal. If we don't handle this case yet, maybe we should not add this method and just skip visiting the nodes?
| @@ -158,6 +161,12 @@ public R visit(AstNode node, A arg) { | |||
| return visitSwitchCase((SwitchCase) node, arg); | |||
| } else if (node instanceof SwitchStatement) { | |||
| return visitSwitchStatement((SwitchStatement) node, arg); | |||
| } else if (node instanceof TaggedTemplateLiteral) { | |||
| return visitTaggedTemplateLiteral((TaggedTemplateLiteral) node, arg); | |||
There was a problem hiding this comment.
See comment above about not visiting these nodes if we don't yet handle them; or is the issue that we'll get an unexpected node type?
In general, what happens right now when we try to pass an ES6 input to WALA, given that we haven't set the language version? Do we just get a parse error in Rhino?
| @@ -1071,4 +1071,38 @@ public void testComplexFinally() | |||
|
|
|||
| CAstCallGraphUtil.dumpCG(B.getCFAContextInterpreter(), B.getPointerAnalysis(), CG); | |||
| } | |||
|
|
|||
| private static final Object[][] assertionsES6Args = | |||
There was a problem hiding this comment.
For the test cases where the template substitution has a function call, can we assert that the appropriate call edge(s) are present?
For javascript, add ES6 Support for rhino 1.7.15, and support Template Literals as a concatenation/addition of strings. Also includes a few tests for Template Literals in "es6.js" file. Tagged Template Literals are not yet supported.