-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3 alpha] docs: add note that internal service methods are not included in generated bindings #3982
[v3 alpha] docs: add note that internal service methods are not included in generated bindings #3982
Conversation
WalkthroughThe documentation for Wails v3 services has been updated with a clarifying note about method bindings. The update focuses on explaining which service methods are not exposed to the frontend, specifically highlighting that Changes
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Adds a small note to the Learn/Services page that calls out the
OnStartup
,OnShutdown
, andServeHTTP
internal methods are not included when the service's bindings are generated.I was refactoring my own version of services into these new lifecycle methods and tested the bindings generation to ensure these methods were not exposed to the frontend. I think this would be good to call out in the docs so others are aware these are treated differently than regular bound methods.
wails/v3/internal/generator/collect/service.go
Line 57 in 91a9929
Type of change
Please select the option that is relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor
.If you checked Linux, please specify the distro and version.
Test Configuration
Please paste the output of
wails doctor
. If you are unable to run this command, please describe your environment in as much detail as possible.Checklist:
website/src/pages/changelog.mdx
with details of this PRSummary by CodeRabbit