0090-01 / C12のテストを追加 #242
Merged
0090-01 / C12のテストを追加 #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#240 へのコメントと同じですが、「ブラウザの文字サイズ変更ボタン」で、適切に伝わるか気になっています。 期待される結果については、相対的な文字の大きさに言及していて、よいと思いました。 |
Merged
nishimotz
reviewed
Sep 11, 2024
WAIC-TEST/HTML/WAIC-TEST-0090-01.md
Outdated
|
|
||
| # テスト手順 (視覚閲覧環境) | ||
|
|
||
| ブラウザの文字サイズ変更ボタンから文字サイズを拡大する |
There was a problem hiding this comment.
ズーム機能ではなく、ブラウザの文字サイズ変更機能を用いて、文字サイズのみを拡大する
nishimotz
reviewed
Oct 2, 2024
WAIC-TEST/HTML/WAIC-TEST-0090-01.md
Outdated
Comment on lines
13
to
25
| # テストの対象となる達成基準 | ||
|
|
||
| 1.4.4 | ||
| 1.4.5（参考） | ||
| 1.4.8 | ||
| 1.4.9（参考） | ||
|
|
||
| # 関連する達成方法 (複数) | ||
|
|
||
| C12 | ||
| C13 | ||
| C14 | ||
|
|
There was a problem hiding this comment.
ここは、複数の項目がある場合はカンマ区切りで揃えていますね。
改行だと区切りが不明確な表示になりそうです。
nishimotz
reviewed
Oct 2, 2024
WAIC-TEST/HTML/WAIC-TEST-0090-01.md
Outdated
Comment on lines
38
to
42
| ```CSS | ||
| strong { | ||
| font-size: 120%; | ||
| } | ||
| ``` |
nishimotz
reviewed
Oct 2, 2024
WAIC-TEST/HTML/WAIC-TEST-0090-01.md
Outdated
|
|
||
| # 期待される結果 (視覚閲覧環境) | ||
|
|
||
| パーセントでフォントサイズが指定されたstrong 要素の「ユーザー」と「非常に」が周囲のテキストより大きく表示される |
There was a problem hiding this comment.
h1 要素と p 要素の両方に「ユーザー」というテキストがあるため、どちらのことかが（ソースを読まなくても）わかる書き方だと親切かなと思いました。
|
ありがとうございます |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#235
ブランチ名とファイル名を変更し再度作成。
過去のレビュー記録 ＃238