Skip to content

Conversation

@Incharajayaram
Copy link

@Incharajayaram Incharajayaram commented Oct 16, 2025

Description

This PR adds a demo implementation of nested InlinePanel functionality within location hours of operation, as suggested in #555. The purpose is to provide a real-world test case for expand/collapse and scroll issues with nested inline panels (#13352).

Implementation Details

  • Added SpecialOpeningHour as a nested Orderable model within LocationOperatingHours
  • Configured nested InlinePanel with proper parent-child relationships
  • Maintains existing functionality while adding demo nested structure

Testing Scope

This implementation serves as a test bed for:

  • Expand/collapse behavior with nested panels
  • Scroll issues in complex inline panel structures
  • General nested InlinePanel functionality in Wagtail admin

Notes

  • This is primarily a technical demo rather than a full feature
  • Can be extended or modified based on testing needs
  • Follows Wagtail patterns for nested inline panels

- Implement SpecialOpeningHour model as nested Orderable
- Add InlinePanel for special hours within regular hours
- Support expand/collapse UI in Wagtail admin
- Maintain backward compatibility with existing hours
@Incharajayaram Incharajayaram changed the title feat: Add nested special hours to location operating hours Demo: Nested InlinePanel Implementation for Testing Oct 16, 2025
@thibaudcolas
Copy link
Member

Thank you for giving this a go @Incharajayaram. I gotta say I don’t understand what a "special opening hour" is? And I don’t understand the unrelated changes to other files of the project?

@Incharajayaram
Copy link
Author

Hi @thibaudcolas, thanks for reviewing and for the feedback!

I’d like to make sure I understand what you’d prefer for this demo before making adjustments. The goal from issue #555 was to add a nested InlinePanel example for testing, so I implemented SpecialOpeningHour as a child of LocationOperatingHours to provide that nested structure.

Could you clarify what you’d like to see instead?

  • Would you prefer a different example (e.g. “HolidayHours” or another real-world use case)?
  • Should the demo live somewhere else than LocationOperatingHours?

Once I have your guidance, I can update the PR accordingly.

Thanks again for your time!

@thibaudcolas
Copy link
Member

thibaudcolas commented Oct 23, 2025

@Incharajayaram I’m not sure I understand your comment, I’m not asking for any changes, just wanting you to clarify how you arrived at what you have so far? Did you use an AI tool to do this work for you? The dotenv setup of the project has nothing to do with InlinePanel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants