Add examples to the duty of protection. #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
approved these changes
Apr 22, 2025
jyasskin
force-pushed
the
protection-examples
branch
from
6413a4b to
78f9aa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure that these are the right set of examples or that any of them have the right content, but I think they roughly cover the content of #9.
There's an obvious question of why I prefer longer examples over incorporating their text into the main explanation of the duty. I think separating the example makes it easier for people to skim the duty itself, and then only read the example if they're looking for more detail. It also gives us space to be more precise about what makes different parts of the examples fit or violate the duties, which again improves the chance that someone reading quickly will get the right idea.
Preview | Diff