Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the HTTP guidance into the "consult other specs" section. #546

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jyasskin
Copy link
Contributor

@jyasskin jyasskin commented Dec 18, 2024

@ylafon, the removed "See" bit comes from your comment in #379, so feel free to object.

I see we have some other proposals to add web-specific HTTP guidance. This PR doesn't preclude adding back a less-redundant section on this space. :)

Fixes #545.


Preview | Diff

@martinthomson
Copy link
Contributor

I'm OK with this, on the basis that we'll likely want to do something about #512 at some point.

@jyasskin
Copy link
Contributor Author

I wonder if we should create a policy of preserving all section ids...

@hober
Copy link
Contributor

hober commented Jan 14, 2025

I wonder if we should create a policy of preserving all section ids...

We should endeavor to avoid breaking any id="" because Cool URIs Don't Change and there may be URLs in the wild with fragment directives pointing at any of them.

Copy link
Contributor

@hober hober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me if you preserve the id="using-http" somewhere sensible.

@jyasskin jyasskin force-pushed the remove-http-guidance branch from 5117cd8 to b8e548c Compare January 15, 2025 01:28
@jyasskin
Copy link
Contributor Author

Done. This would be a little simpler if speced/bikeshed#2184 were fixed, and we can do it more reliably if speced/bikeshed#3007 were available.

@jyasskin jyasskin requested a review from hober January 15, 2025 01:34
@@ -1107,7 +1112,7 @@ even if this means using another character to separate values.
<div class=example>

The <{input/accept}> attribute is a comma-separated list of values,
because it needs to match the syntax of the `Accept` HTTP header. (See [[#using-http|guidance on HTTP headers]])
because it needs to match the syntax of the [:Accept:] HTTP header.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
because it needs to match the syntax of the [:Accept:] HTTP header.
because it needs to match the syntax of the [:Accept:] HTTP header field value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestion is more technically correct, but it's also wordier, and I suspect that nobody's confused by the shorter formulation. I'm inclined not to make the change, but I will if anyone feels strongly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve link text for RFC 9205
4 participants