Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust ThingFilter and ThingDiscovery interfaces #434

Closed
wants to merge 2 commits into from

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Oct 10, 2022

This PR contains the changes to the ThingFilter and ThingDiscovery interfaces that have originally been part of #405.


Preview | Diff

@JKRhb JKRhb changed the title feat: adjust ThingFilter interface feat: adjust ThingFilter interface and ThingDiscovery API Oct 10, 2022
@JKRhb JKRhb changed the title feat: adjust ThingFilter interface and ThingDiscovery API feat: adjust ThingFilter and ThingDiscovery interfaces Oct 10, 2022
@danielpeintner
Copy link
Contributor

Does it make sense to state why you suggest both changes...

w.r.t. url

I think I see the reasoning..

direct and the directory methods need URLs in order to work

w.r.t. to require ThingFilter

Is it because one can pass in null anyway?
Did we check all algorithms?

@JKRhb
Copy link
Member Author

JKRhb commented Oct 17, 2022

Thank you for your comment, @danielpeintner, you are right, the PR needs a bit more clarification 😅 The change of the ThingFilter was related to making the URL mandatory. I think the algorithms do indeed need to be adjusted, I did not manage to revisit them yet.

@danielpeintner
Copy link
Contributor

Call 2022-10-17

@danielpeintner danielpeintner added the discovery Relates to discovery and/or relates to joint work/discussions with the discovery task force label Oct 17, 2022
@danielpeintner
Copy link
Contributor

Closing since we move on with #364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discovery Relates to discovery and/or relates to joint work/discussions with the discovery task force
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants