Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publication Prep #290

Merged
merged 21 commits into from
May 31, 2023
Merged

Publication Prep #290

merged 21 commits into from
May 31, 2023

Conversation

egekorkan
Copy link
Contributor

@egekorkan egekorkan commented May 24, 2023

I have done the following:

Validation results (No need to manually update):

  • Link Checker - No errors (it shows an error for this Note's link)
  • Pubrules Checker: Errors exist but they can be ignored.
    • There are some errors from Netlify that can be ignored.
    • The center error from the HTML Validator is also here. It can be ignored.
  • CSS Checker - No errors
  • HTML Validator - There is an error about using <center> but this is coming from Netlify and can be ignored.

Preview | Diff

@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for wot-binding-templates ready!

Name Link
🔨 Latest commit 3563204
🔍 Latest deploy log https://app.netlify.com/sites/wot-binding-templates/deploys/646fd62b122a020008262c48
😎 Deploy Preview https://deploy-preview-290--wot-binding-templates.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@egekorkan
Copy link
Contributor Author

egekorkan commented May 24, 2023

The Netlify version can be used for the pubrules check: https://deploy-preview-290--wot-binding-templates.netlify.app/publication/note3/overview

@egekorkan
Copy link
Contributor Author

Pubrules error: [EXCEPTION] The document "Web of Things (WoT) Binding Templates" seems to be an Editor's Draft, which is not supported.

It is not clear from previous instructions on what needs to be changed to move from ED to Note

@egekorkan
Copy link
Contributor Author

egekorkan commented May 24, 2023

Call of 24.05:

  • The respec parameter should be changed to "Note" from "ED" and the process should be done again.

  • Document the HTML Tidy commands to write to the Overview.html file

  • Once the static HTML is generated, go through the link checker, validation checker and pubrules.

  • Add https://www.w3.org/Guide to the readme

@egekorkan egekorkan requested a review from mjkoster as a code owner May 24, 2023 22:03
@egekorkan
Copy link
Contributor Author

All the checks except some CSS that is generated by respec are passing. @danielpeintner did you have the same issue in Scripting API? You can find them at the CSS validator or in the HTML validator of W3C.

@danielpeintner
Copy link
Contributor

@danielpeintner did you have the same issue in Scripting API?

We did run into some other ReSpec issues, see w3c/wot-scripting-api#480

@egekorkan
Copy link
Contributor Author

OK so I checked where the error comes from and it is not due to respec, also not the errors like in @danielpeintner case above. The static HTML generated from respec is correct but HTML tidy adds errors.

CSS validation of static.html

@egekorkan
Copy link
Contributor Author

The addition of CDATA seems to be a bug that others counter (see here). I will go around this issue for now.

@egekorkan egekorkan requested a review from ashimura May 25, 2023 21:49
@egekorkan egekorkan merged commit 2ccbd44 into main May 31, 2023
@egekorkan egekorkan deleted the ege-publication-prep branch May 31, 2023 14:47
@egekorkan egekorkan mentioned this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants