Add SFrame packetization handling for SFrameTransform #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jan-ivar, @guidou, @dontcallmedom, here is the PR based on yesterday's meeting. |
|
@alvestrand, this also introduces the |
youennf
force-pushed
the
sframe-packetization-integration
branch
from
f580cb7 to
4f74b13
Compare
youennf
force-pushed
the
sframe-packetization-integration
branch
from
4f74b13 to
6226b9a
Compare
Introduce RTCRtpScriptTransformType with "sframe" value.
youennf
force-pushed
the
sframe-packetization-integration
branch
from
6226b9a to
17e6cf2
Compare
jan-ivar
reviewed
May 22, 2025
| @@ -181,6 +188,7 @@ A RTCRtpTransform has private slots: | |||
| * `[[readable]]` of type {{ReadableStream}}. | |||
| * `[[writable]]` of type {{WritableStream}}. | |||
| * `[[owner]]` of type {{RTCRtpSender}} or {{RTCRtpReceiver}}, initialized to null. | |||
| * `[[useSFrame]]` of type boolean. // FIXME: Decide whether augmenting this boolean with either cipher suite support or whether doing frame vs. packet based encryption. | |||
There was a problem hiding this comment.
Can we do the FIXME as a note so it shows up in the spec?
jan-ivar
reviewed
May 22, 2025
| [Exposed=Window] | ||
| interface RTCRtpScriptTransform { | ||
| constructor(Worker worker, optional any options, optional sequence<object> transfer); | ||
| constructor(Worker worker, optional any options, optional sequence<object> transfer, optional RTCRtpScriptTransformType type); |
There was a problem hiding this comment.
I think I'd prefer to not add more arguments to the constructor but instead reuse the options object we already overload to send to worker. I'm not super worried about name collisions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on last WebRTC WG meeting and this week's chair meeting, here is a draft of how SFrame packetization could be integrated with SFrameTransform and RTCRtpScriptTransform.
Preview | Diff