Fix CSS test on base property definitions #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test did not take into account the possibility that the base definition of a CSS property could be in a delta spec. That's currently the case for the `continue` property: defined in `css-overflow-4`, extended in `css-overflow-5`. Not done here but the test could also be extended to make sure that the base definition is defined in a delta spec that is logically *before* the spec that extends the definition. The use of a separate array is meant to ease that further update. Closes #1272.
dontcallmedom
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test did not take into account the possibility that the base definition of a CSS property could be in a delta spec. That's currently the case for the
continueproperty: defined incss-overflow-4, extended incss-overflow-5.Not done here but the test could also be extended to make sure that the base definition is defined in a delta spec that is logically before the spec that extends the definition. The use of a separate array is meant to ease that further update.
Closes #1272.