Skip to content

Conversation

@lutien
Copy link
Member

@lutien lutien commented Oct 15, 2025

Add hook which is going to be used in html spec to set emulation for navigator.language/s.

HTML spec draft PR: whatwg/html#11793.


Preview | Diff

@lutien lutien marked this pull request as ready for review October 15, 2025 09:44
Copy link
Contributor

@juliandescottes juliandescottes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question regarding the number of algorithms defined here, but otherwise this looks good given the changes in the HTML draft PR.

@lutien lutien force-pushed the add-emulation-of-language branch from 4c9de0d to d5222bb Compare October 21, 2025 12:42
Co-authored-by: Maksim Sadym <[email protected]>
@lutien
Copy link
Member Author

lutien commented Oct 21, 2025

Alright, thanks for the reviews! I'm going to merge it now.

@sadym-chromium, could you create an issue on your side to implement this so I could link it in the PR for html spec?

@lutien lutien merged commit a51a94f into w3c:main Oct 21, 2025
5 checks passed
@lutien lutien deleted the add-emulation-of-language branch October 21, 2025 13:00
github-actions bot added a commit that referenced this pull request Oct 21, 2025
SHA: a51a94f
Reason: push, by lutien

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sadym-chromium
Copy link
Contributor

Alright, thanks for the reviews! I'm going to merge it now.

@sadym-chromium, could you create an issue on your side to implement this so I could link it in the PR for html spec?

GoogleChromeLabs/chromium-bidi#3863

Please note that you also need WPT tests before landing HTML PR.

@lutien
Copy link
Member Author

lutien commented Oct 21, 2025

Alright, thanks for the reviews! I'm going to merge it now.
@sadym-chromium, could you create an issue on your side to implement this so I could link it in the PR for html spec?

GoogleChromeLabs/chromium-bidi#3863

Thanks for creating the issue!

Please note that you also need WPT tests before landing HTML PR.

The PR to update the tests is actually here: web-platform-tests/wpt#55453.

@sadym-chromium
Copy link
Contributor

@lutien hope it's not too late, but what I just thought about is maybe it makes sense to split the locale and language? i.e. we can either extend the emulation.setLocaleOverride command with a new parameter language, or introduce a new command emulation.setLanguageOverride.

@lutien
Copy link
Member Author

lutien commented Oct 23, 2025

@lutien hope it's not too late, but what I just thought about is maybe it makes sense to split the locale and language? i.e. we can either extend the emulation.setLocaleOverride command with a new parameter language, or introduce a new command emulation.setLanguageOverride.

I think according to our discussions here, the consensus was that all the values have to synchronized, so there is no point to have multiple arguments or commands. Do you have any specific use/reason in mind where it would make sense to split?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants