Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/Added page title to reflect ACT rule order and added lang where missing #317

Open
wants to merge 63 commits into
base: main
Choose a base branch
from

Conversation

giacomo-petri
Copy link
Contributor

@giacomo-petri giacomo-petri commented Dec 30, 2024

Closes: #269

This PR addresses only approved rules.

Issues solved:

  • In [73f2c2] Autocomplete attribute has valid value testcase efcd5df49b39506dac34a310f4b8bc0df71716d3.html the page title of Passed Example 9 is Passed Example 8. Updated page title to reflect the ACT order.
  • In [97a4e1] Button has non-empty accessible name testcase 00fe207175e40ddc81a86fb09504e5fa33b7dd0f.html the page title of Passed Example 6 is missing. Moreover the lang attribute is missing too. Updated page title to reflect the ACT order and added lang="en" to the html tag.
  • In [97a4e1] Button has non-empty accessible name testcase 1a6035f4f09b339ac53bc547fc727a51ab05a3c6.html the page title of Failed Example 4 is missing. Moreover the lang attribute is missing too. Updated page title to reflect the ACT order and added lang="en" to the html tag.
  • In [de46e4] Element with lang attribute has valid language tag
    testcase a746b387d13dc61266d1fcde19b91b89441b1be7.html the page title of Passing Example 1 is missing. Updated page title to reflect the ACT order.
  • In [de46e4] Element with lang attribute has valid language tag
    testcase 1583a11fb07127fb3315fa19f3baaf876aa42aa4.html the page title of Passing Example 2 is missing. Updated page title to reflect the ACT order.
  • In [de46e4] Element with lang attribute has valid language tag
    testcase 034e1e1a46cfa6d3fe3bcc69ac45ffb6c5d55148.html the page title of Passing Example 3 is missing. Updated page title to reflect the ACT order.
  • In [de46e4] Element with lang attribute has valid language tag
    testcase d8c5a59532ae0624edd875aea31ef39086873b7a.html the page title of Passing Example 4 is missing. Updated page title to reflect the ACT order.
  • In [de46e4] Element with lang attribute has valid language tag
    testcase cecfce83c949d20c816a0e43cbc4c26a3468754b.html the page title of Passing Example 5 is missing. Updated page title to reflect the ACT order.
  • In [de46e4] Element with lang attribute has valid language tag
    testcase b1765660b28464b5a73e502ef30b7370ba294ff5.html the page title of Failed Example 1 is missing. Updated page title to reflect the ACT order.
  • In [de46e4] Element with lang attribute has valid language tag
    testcase 49b66676ed867c75368e31c1e06b28255df8089e.html the page title of Failed Example 2 is missing. Updated page title to reflect the ACT order.
  • In [de46e4] Element with lang attribute has valid language tag
    testcase 78de8b1ca470302aebb53065c32eddf08da008b5.html the page title of Failed Example 3 is missing. Updated page title to reflect the ACT order.
  • In [de46e4] Element with lang attribute has valid language tag
    testcase 795698c08fc5d404b649d0c367bedc3e83462d43.html the page title of Failed Example 4 is missing. Updated page title to reflect the ACT order.
  • In [de46e4] Element with lang attribute has valid language tag
    testcase d8ba52b5fa5e123def1f778821219aaec20ca0fe.html the page title of Failed Example 5 is missing. Updated page title to reflect the ACT order.
  • In [de46e4] Element with lang attribute has valid language tag
    testcase 61f81c57325a77a89481f036e4e2116399fb6714.html the page title of Failed Example 6 is missing. Updated page title to reflect the ACT order.
  • In [de46e4] Element with lang attribute has valid language tag
    testcase 5ba0306adadd581e4331b9415c2ef9f8ecccc0f2.html the page title of Failed Example 7 is missing. Updated page title to reflect the ACT order.
  • In [de46e4] Element with lang attribute has valid language tag
    testcase 915cdae554a817caa4792101fde1adf14563227d.html the page title of Failed Example 8 is missing. Updated page title to reflect the ACT order.
  • In [de46e4] Element with lang attribute has valid language tag
    testcase 50e733e0c505a556fc53e6265eb5b432823570f7.html the page title of Failed Example 9 is missing. Updated page title to reflect the ACT order.
  • In [b5c3f8] HTML page has lang attribute testcase 0fac26928e2bf6b7db6c7f46a1e0ab50aaa8a7c1.html the page title of Passed Example 1 is missing. Updated page title to reflect the ACT order.
  • In [b5c3f8] HTML page has lang attribute testcase 473352935acf2463b14dbd8e38073e913eeb5c08 the page title of Failed Example 1 is missing. Updated page title to reflect the ACT order.
  • In [b5c3f8] HTML page has lang attribute testcase 98681b2a7949e49b2da1b353f70e688528fe7ddc.html the page title of Failed Example 2 is missing. Updated page title to reflect the ACT order.
  • In [b5c3f8] HTML page has lang attribute testcase 4ea0280617a1b71dcc327356484f8767919b0f40.html the page title of Failed Example 3 is missing. Updated page title to reflect the ACT order.
  • In [bf051a] HTML page has lang attribute testcase 4f94c3e26f43701d91db403fe26cd8894bdc8ccf.html the page title of Failed Example 4 is missing. Updated page title to reflect the ACT order.
  • In [bf051a] HTML page lang attribute has valid language tag testcase 7d8c4fd028c504d10c4e5e9bd7183c139549e1a1.html the page title of Passed Example 1 is missing. Updated page title to reflect the ACT order.
  • In [bf051a] HTML page lang attribute has valid language tag testcase a49f11c86ad81c4d42700dfca58a7eeec377f02e.html the page title of Passed Example 2 is missing. Updated page title to reflect the ACT order.
  • In [bf051a] HTML page lang attribute has valid language tag testcase b7a35f8080e756776877bca013a910dafde8ef73.html the page title of Failed Example 1 is missing. Updated page title to reflect the ACT order.
  • In [bf051a] HTML page lang attribute has valid language tag testcase 5c998eef8cb13a8f577dade1a3b9fe591bc69204.html the page title of Failed Example 2 is missing. Updated page title to reflect the ACT order.
  • In [bf051a] HTML page lang attribute has valid language tag testcase 0f73e7179e17f050380f0ea350d2551611820fd5.html the page title of Failed Example 3 is missing. Updated page title to reflect the ACT order.
  • In [bf051a] HTML page lang attribute has valid language tag testcase b64d767d873269ff00966630e34ab198fc24368f.html the page title of Failed Example 4 is missing. Updated page title to reflect the ACT order.
  • In [qt1vmo] Image accessible name is descriptive testcase af4423575333947073fa3729f502ff0a0c6c2fbf.html the page title of Passed Example 1 is missing. Updated page title to reflect the ACT order.
  • In [qt1vmo] Image accessible name is descriptive testcase 5d314574052bf16676abb0e9a67e48dd70116c2e.html the page title of Passed Example 2 is missing. Updated page title to reflect the ACT order.
  • In [qt1vmo] Image accessible name is descriptive testcase 2a66c7b8d8ef78d350b1c995e0ad232008f6564f.html the page title of Passed Example 3 is missing. Updated page title to reflect the ACT order.
  • In [qt1vmo] Image accessible name is descriptive testcase 485f10faf222cd48fea2ab3ee79c2d354e51ea33.html the page title of Failed Example 1 is missing. Updated page title to reflect the ACT order.
  • In [qt1vmo] Image accessible name is descriptive testcase 2f7d82593e287df64b7459695e355a840254255c.html the page title of Failed Example 2 is missing. Updated page title to reflect the ACT order.
  • In [qt1vmo] Image accessible name is descriptive testcase bac67a5a2ada971100bbec89961ad3e6c869f268.html the page title of Failed Example 3 is missing. Updated page title to reflect the ACT order.
  • In [c487ae] Link has non-empty accessible name testcase dee6c55162904cfb77c7f65614c4e6ae2baacea2.html the page title and lang of Passed Example 9 is missing. Updated lang and page title to reflect the ACT order.
  • In [m6b1q3] Menuitem has non-empty accessible name testcase c261108b8bb62e118a47a52d0a157b4265a6e143.html the page title of Failed Example 2 is missing. Updated the page title to reflect the ACT order.
  • In [bc659a] Meta element has no refresh delay
    testcase b5ca868de7980f6944142ecdb849f47ad2cdfb5c.html the page title of Passed Example 3 is missing. Updated the page title to reflect the ACT order.
  • In [bc659a] Meta element has no refresh delay testcase 56857820788db21498e95a5cbba65d59a9a2b892.html the page title of Failed Example 1 is missing. Updated the page title to reflect the ACT order.
  • In [bc659a] Meta element has no refresh delay testcase 96c7657d21888cd05edd297d44a8fd554b21c908.html the page title of Failed Example 2 is missing. Updated the page title to reflect the ACT order.
  • In [bc659a] Meta element has no refresh delay testcase b2e7f3e00ffce0a2a1078f860452814e6445445d.html the page title of Failed Example 3 is missing. Updated the page title to reflect the ACT order.
  • In [bc659a] Meta element has no refresh delay testcase 5d4d5b214459c8a0779600ab39a5668003271c62.html the page title of Failed Example 4 is missing. Updated the page title to reflect the ACT order.
  • In [bisz58] Meta element has no refresh delay (no exception) testcase ecc787569c06640f3748ae90e2b57fb51c1e22d8.html the page title of Failed Example 1 is missing. Updated the page title to reflect the ACT order.
  • In [bisz58] Meta element has no refresh delay (no exception) testcase d0672e81d17313f7ef156f3bc6e43c68143a5f45.html the page title of Failed Example 2 is missing. Updated the page title to reflect the ACT order.
  • In [bisz58] Meta element has no refresh delay (no exception) testcase b8aad77e3ff2fa8d0272fac5362566ff79afad7f.html the page title of Failed Example 3 is missing. Updated the page title to reflect the ACT order.
  • In [b4f0c3] Meta viewport allows for zoom testcase 312146d84331c7214ed6919391ad955098eff516.html the page lanfg of Passed Example 1 is missing. Updated the lang. Moreover, page title was generic and the same for each example ("Simple page showing random text"). Added a bit of context adding the example number in front (e.g., "Passed Example $n - Simple page showing random text")
  • In [b4f0c3] Meta viewport allows for zoom testcase d143bfe343ecf75bceb92b6fc9807cc5f453b319.html the page lanfg of Passed Example 2 is missing. Updated the lang. Moreover, page title was generic and the same for each example ("Simple page showing random text"). Added a bit of context adding the example number in front (e.g., "Passed Example $n - Simple page showing random text")
  • In [b4f0c3] Meta viewport allows for zoom testcase 4ade33e41dda291c9078e56ca2a95c4825dbc1fe.html the page lanfg of Passed Example 3 is missing. Updated the lang. Moreover, page title was generic and the same for each example ("Simple page showing random text"). Added a bit of context adding the example number in front (e.g., "Passed Example $n - Simple page showing random text")
  • In [b4f0c3] Meta viewport allows for zoom testcase accc6adf094723693593ca3c6308f81945930dae.html the page lanfg of Failed Example 1 is missing. Updated the lang. Moreover, page title was generic and the same for each example ("Simple page showing random text"). Added a bit of context adding the example number in front (e.g., "Passed Example $n - Simple page showing random text")
  • In [b4f0c3] Meta viewport allows for zoom testcase a1240b31761f65c92a8f6d08ed7105ee822d0ebc.html the page lanfg of Failed Example 2 is missing. Updated the lang. Moreover, page title was generic and the same for each example ("Simple page showing random text"). Added a bit of context adding the example number in front (e.g., "Passed Example $n - Simple page showing random text")
  • In [b4f0c3] Meta viewport allows for zoom testcase c7e4980eb42d0b138684ac1e28318a197d86ccfc.html the page lanfg of Failed Example 3 is missing. Updated the lang. Moreover, page title was generic and the same for each example ("Simple page showing random text"). Added a bit of context adding the example number in front (e.g., "Passed Example $n - Simple page showing random text")
  • In [b4f0c3] Meta viewport allows for zoom testcase e5695989a43a3297cf6b78182014c7a3848ff7e1.html the page lanfg of Failed Example 4 is missing. Updated the lang. Moreover, page title was generic and the same for each example ("Simple page showing random text"). Added a bit of context adding the example number in front (e.g., "Passed Example $n - Simple page showing random text")
  • In [8fc3b6] Object element rendering non-text content has non-empty accessible name testcase c3ed1c920db04a7b13d043fae5766694cf50d561.html the page title and lang of Passed Example 4 is missing. Updated lang and page title to reflect the ACT order.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for wai-wcag-act-rules ready!

Name Link
🔨 Latest commit 06576cd
🔍 Latest deploy log https://app.netlify.com/sites/wai-wcag-act-rules/deploys/6773dc2289bcbb0008730af9
😎 Deploy Preview https://deploy-preview-317--wai-wcag-act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@giacomo-petri giacomo-petri changed the title DRAFT - Autocomplete attribute has valid value [73f2c2] - Update page title to reflect ACT rule order Update/Added page title to reflect ACT rule order and added lang where missing Dec 31, 2024
@giacomo-petri
Copy link
Contributor Author

@carlosapaduarte @Jym77, I'm not able to ask for reviewers or add a label.

@carlosapaduarte
Copy link
Contributor

@carlosapaduarte @Jym77, I'm not able to ask for reviewers or add a label.

Neither can we. That is because this is the wcag-act-rules and not the act-rules.github.io where we usually work. Are you sure you want to PR into this repo @giacomo-petri ?

@giacomo-petri
Copy link
Contributor Author

@carlosapaduarte,
Yes, I believe so. I'm assuming the test case examples correspond to the results of these pages (e.g., https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/afw4f7/b1a65bd18381a1ea4ad3077fd98c50368947012c.html).

@carlosapaduarte
Copy link
Contributor

@giacomo-petri I might be wrong but I'm under the impression that these files get built automatically from the sources in the act-rules.github.io repo.

@WilcoFiers should know what is the best way to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some of the test examples lack a page title and lang
2 participants