Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAI website update 2024-12-16 #314

Merged
merged 5 commits into from
Dec 19, 2024
Merged

WAI website update 2024-12-16 #314

merged 5 commits into from
Dec 19, 2024

Conversation

github-actions[bot]
Copy link

This is an automated pull request to publish ACT content to the WAI website.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for wai-wcag-act-rules ready!

Name Link
🔨 Latest commit cb40747
🔍 Latest deploy log https://app.netlify.com/sites/wai-wcag-act-rules/deploys/67630e3681aedc0008f542e9
😎 Deploy Preview https://deploy-preview-314--wai-wcag-act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

"title": "aria_accessiblename_exists:fail_no_accessible_name_image",
"isPartOf": [
"WCAG2:name-role-value",
[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-montalvo I understand from EARL Reporting Format – Test Criterion that isPartOf contains "strings, listing the WCAG success criteria that fail when the rule or procedure fails".

What is the purpose of this empty array in this context? This pattern seems new and is used multiple times in this pull request.

Copy link
Contributor

@daniel-montalvo daniel-montalvo Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @remibetin

Indeed, this PR introduces many more occurrences of this empty array, but these are not the only ones. For example, see equal-access.json, which apparently was last edited 4 June 2024. Is there any impact in the UI that these new instances are creating and I may be missing?

Copy link
Member

@remibetin remibetin Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any impact in the UI that these new instances are creating and I may be missing?

Not that I am aware of, but I do not have in-depth knowledge of this part of the website.
From quick investigation, I can't find any use of the isPartOf property in ACT Rules pages.

@WilcoFiers Are we missing something?

Copy link
Member

@remibetin remibetin Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed with @shawna-slh, I have raised a separate issue #315

Copy link
Contributor

@daniel-montalvo daniel-montalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@remibetin remibetin merged commit 7b75ec4 into publication Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants