-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WAI website update 2024-12-16 #314
Conversation
✅ Deploy Preview for wai-wcag-act-rules ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
"title": "aria_accessiblename_exists:fail_no_accessible_name_image", | ||
"isPartOf": [ | ||
"WCAG2:name-role-value", | ||
[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daniel-montalvo I understand from EARL Reporting Format – Test Criterion that isPartOf
contains "strings, listing the WCAG success criteria that fail when the rule or procedure fails".
What is the purpose of this empty array in this context? This pattern seems new and is used multiple times in this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @remibetin
Indeed, this PR introduces many more occurrences of this empty array, but these are not the only ones. For example, see equal-access.json, which apparently was last edited 4 June 2024. Is there any impact in the UI that these new instances are creating and I may be missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any impact in the UI that these new instances are creating and I may be missing?
Not that I am aware of, but I do not have in-depth knowledge of this part of the website.
From quick investigation, I can't find any use of the isPartOf
property in ACT Rules pages.
@WilcoFiers Are we missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As agreed with @shawna-slh, I have raised a separate issue #315
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This is an automated pull request to publish ACT content to the WAI website.