Changing the references to the controller document to cid #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wind4Greg
approved these changes
Dec 10, 2024
dlongley
approved these changes
Dec 11, 2024
|
@dlongley and @Wind4Greg I re-requested review because I have also changed the class name. |
dlongley
approved these changes
Dec 13, 2024
peacekeeper
approved these changes
Dec 13, 2024
Wind4Greg
approved these changes
Dec 16, 2024
|
@msporny is there any reason this is not yet merged? I want to sync the error codes over the two documents and sync them with the VCDM spec (see w3c/cid#134 (comment)) but this PR would possibly interfere during the merge, and I want to avoid that... |
msporny
approved these changes
Jan 6, 2025
I just missed it... too many specs in flight, difficult to keep track of all PRs for all of them. Merging now. |
|
Editorial, multiple reviews, changes requested and made, no objections, merging. |
msporny
added
CR1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the outcome of w3c/cid#132 is relevant here. If the decision is to change the concept, then the
ControllerDocumentclass must be changed, too.UPDATED:
In view of w3c/cid#132 and w3c/cid#134, the class name has also been changed to
ControlledIdentifierDocumentin 8e555e8