Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When updating reports, delete those that no longer apply #242

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

dontcallmedom
Copy link
Member

closes #241

dontcallmedom added a commit that referenced this pull request Nov 23, 2022
as identified by #242
Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files are deleted from the local filesystem but isn't the goal to commit and push these changes onto the repo?

Co-authored-by: François Daoust <[email protected]>
@dontcallmedom
Copy link
Member Author

The files are deleted from the local filesystem but isn't the goal to commit and push these changes onto the repo?

The --update mode of the CLI is at the moment not interacting with git on purpose - this is left at the discretion of the local user to review which changes should be committed / pushed.

The reasoning for that design is that --update is mostly meant for a manual processing approach (vs a CI based one), and so leaving more room to the user to review & decide if the results of the update process make sense feels more appropriate.

(and it is meant for a manual processing as I'm, probably naively, hoping we won't get back in a similar situation of reports that are pending submissions for several months)

@tidoust tidoust self-requested a review November 23, 2022 15:09
Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. The update mode does not update the repository. What a nice name for this mode ;)

@dontcallmedom dontcallmedom merged commit a73e0b0 into main Nov 23, 2022
@dontcallmedom dontcallmedom deleted the delete-empty-reports branch November 23, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable removal of outdated reports
2 participants