Add browser binding to the secure payment confirmation spec #286
Conversation
pejic
force-pushed
the
main
branch
2 times, most recently
from
c5e83b6 to
aac5dad
Compare
stephenmcgruer
left a comment
stephenmcgruer
left a comment
There was a problem hiding this comment.
Tried to keep this first pass to meta-level commentary, and sorry again for the delay in reviewing!
pejic
force-pushed
the
main
branch
2 times, most recently
from
a9bdc90 to
7a9c1c3
Compare
stephenmcgruer
left a comment
stephenmcgruer
left a comment
There was a problem hiding this comment.
High level this is looking good to me - almost all my comments are nits and bikeshed related things.
pejic
force-pushed
the
main
branch
3 times, most recently
from
007c502 to
f68533d
Compare
stephenmcgruer
left a comment
stephenmcgruer
left a comment
There was a problem hiding this comment.
Some more minor nits, but overall this LGTM as a solid foundation for BBKs in the spec. There is still more to add, notably we need to add Security & Privacy Considerations for BBKs, but I think we can do that in a separate PR in the future.
Note that we should not land this yet. Firstly, I'm sure Dominic may have input as a spec mentor (thanks in advance Dominic!), as may Ian as a reviewer. However on top of that, we should give the Working Group the chance to review the content before this lands. @ianbjacobs - I would prefer not to wait until the 24th to do that, do you think it would suffice to send the preview to the Working Group mailing list and invite feedback that way?
(Even after this lands we can always come back and change it, of course!!)
Thank you Slobo for your work here!
pejic
left a comment
pejic
left a comment
There was a problem hiding this comment.
Thanks Dominic for the feedback!
domfarolino
left a comment
domfarolino
left a comment
There was a problem hiding this comment.
Looking better. There are still lots of strange instances where you describe a step and then actually make it technical by running algorithms and passing arguments as an afterthought. Those need to be cleaned up to just read like natural spec code. See the last review comment in this review.
pejic
force-pushed
the
main
branch
2 times, most recently
from
956b4e4 to
4d19ae6
Compare
pejic
force-pushed
the
main
branch
2 times, most recently
from
246c6e5 to
525ff98
Compare
pejic
left a comment
pejic
left a comment
There was a problem hiding this comment.
Thanks for the feedback @domfarolino. Could you take another look?
This change adds browser bound keys to the secure payment confirmation spec. See issue 271, w3c#271.
| spec:i18n-glossary; type:dfn; text:bidi isolation | ||
| spec:i18n-glossary; type:dfn; text:language priority list | ||
| spec:infra; type:dfn; text:list | ||
| spec:infra; type:dfn; text:user agent |
There was a problem hiding this comment.
I believe both of these terms are "exported" publicly from infra, so they don't need to be manually referenced in this the anchors block. I suspect the same is true with other links in this PR too, please check them out.
There was a problem hiding this comment.
Checked all definitions be removing them one by one, and seeing whether bikeshed gives errors or warnings. Some were removable. For the infra ones: bikeshed gives me a warning:
LINE 1760:24: Multiple possible 'list' dfn refs.
Arbitrarily chose https://tc39.es/ecma262/multipage/ecmascript-data-types-and-values.html#sec-list-and-record-specification-type
To auto-select one of the following refs, insert one of these lines into a <pre class=link-defaults> block:
spec:ecmascript; type:dfn; text:list
spec:infra; type:dfn; text:list
spec:url; type:dfn; text:list
[=list=]
There was a problem hiding this comment.
You should follow the instructions and add a <pre class=link-defaults> block with spec:infra; type:dfn; text:list in it.
There was a problem hiding this comment.
The list and user agent are already in the link defaults block (starts on line 95 in the latest version), so I think this is good as it stands. However, I could be misunderstanding.
pejic
left a comment
pejic
left a comment
There was a problem hiding this comment.
Thanks again for the feedback, @domfarolino!
| spec:i18n-glossary; type:dfn; text:bidi isolation | ||
| spec:i18n-glossary; type:dfn; text:language priority list | ||
| spec:infra; type:dfn; text:list | ||
| spec:infra; type:dfn; text:user agent |
There was a problem hiding this comment.
Checked all definitions be removing them one by one, and seeing whether bikeshed gives errors or warnings. Some were removable. For the infra ones: bikeshed gives me a warning:
LINE 1760:24: Multiple possible 'list' dfn refs.
Arbitrarily chose https://tc39.es/ecma262/multipage/ecmascript-data-types-and-values.html#sec-list-and-record-specification-type
To auto-select one of the following refs, insert one of these lines into a <pre class=link-defaults> block:
spec:ecmascript; type:dfn; text:list
spec:infra; type:dfn; text:list
spec:url; type:dfn; text:list
[=list=]
|
Thank you Dominic, Ian, and Stephen for the reviews on Browser Bound Keys! |
4 participants
See #271
Preview | Diff