EPUB techniques updated #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeKerscher
requested review from
mattgarrish,
gregoriopellegrino,
clapierre,
madeleinerothberg,
avneeshsingh and
gautierchomel
gregoriopellegrino
requested changes
Dec 30, 2024
| <span><b>THEN</b> display <code id="rich-content-accessible-math-as-latex">"Math as LaTex"</code>.</span> | ||
| </li> | ||
| <li> | ||
| <span><b>ELSE IF</b> <var>contains_math_formula</var> <b>AND</b> <var>short_textual_alternative_images</var>:</span> |
There was a problem hiding this comment.
Here I think you should refer to the metadata accessibilityFeature = describedMath
| rich-content-accessible- | ||
| rich-content-accessible-chemistry-as-latex | ||
| <li> | ||
| <span><b>IF</b> <var>charts_diagrams_as_non_graphical_data</var> <b>OR</b> <var>full_alternative_textual_descriptions</var>:</span> |
There was a problem hiding this comment.
I don't think there is the charts_diagrams_as_non_graphical_data metadata in EPUB a11y metadata, I think we should refer to accessibilityFeature = longDescription
| <span><b>IF</b> (<var>contains_charts_diagrams</var> <b>OR</b> <var>contains_chemical_formula</var> <b>OR</b> <var>contains_math_formula</var>) <b>AND</b> <b>NOT</b> (<var>long_text_descriptions</var> <b>OR</b> <var>chemical_formula_as_chemml</var> <b>OR</b> <var>math_formula_as_latex</var> <b>OR</b> <var>math_formula_as_mathml</var>):</span> | ||
| <span><b>THEN</b> display <code id="rich-content-unknown">"No information is available"</code>.</span> | ||
| <span><b>IF</b> <b>NOT</b> (<var>math_formula_as_mathml</var> <b>OR</b> <var>math_formula_as_latex</var> <b>OR</b> (<var>contains_math_formula</var> <b>AND</b> <var>short_textual_alternative_images</var>) <b>OR</b> <var>chemical_formula_as_mathml</var> <b>OR</b> <var>charts_diagrams_as_non_graphical_data</var> <b>OR</b> <var>full_alternative_textual_descriptions</var> <b>OR</b> <var>closed_captions</var> <b>OR</b> <var>open_captions</var> <b>OR</b> <var>transcript</var>):</span> | ||
| <span><b>THEN</b> either omit this key information if metadata is missing or display <code id="rich-content-unknown">"No information is available"</code>.</span> |
There was a problem hiding this comment.
To be revised based on the correct variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started by validating and checking the spelling in the file. There are still some British spellings instead of US English.
I worked through the items @gregoriopellegrino listed.
I mainly worked on the instructions. In the Rich content section, I added a variable for Chemistry as LaTex.
There is a lot to go through.
I did not get to the Additional information section.
It would be good to update the Excel sheet, which should uncover issues.
Looking forward to a list of what to change next.