Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-masking-1] Fix overlapping <rect()> #468

Closed
wants to merge 1 commit into from

Conversation

cdoublev
Copy link
Contributor

@cdoublev cdoublev commented Sep 2, 2022

The <rect()> definition for clip is overlapping with the newer <rect()> definition in CSS Basic Shapes. This change inlines the definition for clip instead of using a production type.

Fixes w3c/csswg-drafts#7219

@w3cbot
Copy link

w3cbot commented Sep 2, 2022

svgeesus marked as non substantive for IPR from ash-nazg.

@cdoublev
Copy link
Contributor Author

cdoublev commented Sep 3, 2022

Actually I think the following is also required:

-   : <dfn function>rect()</dfn> = rect( <<clip/top>>, <<clip/right>>, <<clip/bottom>>, <<clip/left>> )
+   : <dfn value>rect()</dfn> = rect( <<clip/top>>, <<clip/right>>, <<clip/bottom>>, <<clip/left>> )

Waiting for your review.

Related: w3c/csswg-drafts#7682

@cdoublev
Copy link
Contributor Author

cdoublev commented Aug 5, 2023

I reverted the commit described by my previous comment, following w3c/csswg-drafts#7682 (comment):

Right, the functions should still be marked as functions rather than values, but their context-sensitivity (indicated by the presence of the for value) means they can't be meaningfully used as productions.

The `<rect()>` definition for `clip` is overlapping with the newer `<rect()>` definition in CSS Basic Shapes. This change inlines the definition for `clip` instead of using a production type.
@cdoublev
Copy link
Contributor Author

cdoublev commented Oct 4, 2023

After all, I prefer rect([<length> | auto]{4} | [<length> | auto]#{4}), which gets rid of redudant <top>, <right>, <bottom>, <left>, and endorse this:

User agents must support separation with commas, but may also support separation without commas (but not a combination), because a previous revision of this specification was ambiguous in this respect.

But it requires larger changes in the specification, and this PR does not seem to spark interest, therefore I prefer to close it and let someone make the appropriate changes, if any.

@cdoublev cdoublev closed this Oct 4, 2023
@cdoublev cdoublev deleted the patch-1 branch October 4, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[css-masking-1] Fix value definition of deprecated clip property
2 participants