Zip file is not closed properly #1547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeltour
added
status: ready for review
type: improvement
rdeltour
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Thanks for the PR @Kamik423, and sorry for the late review.
I'll do a little cleanup when merging with little tweaks (mostly for cosmetics, but also to call the close() method in a finally block). But otherwise looks good to me!
|
Rebased and applied as 96a6e1c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For checking the contents of an EPUB, a
java.util.zip.ZipFile-object is created. This opens the file for introspection. The file can be closed in two different ways: By explicitly being closed once epubcheck is done with it (calling the.close()method), which is not done in this case; or by waiting for the garbage collection to clean up the object which results in a close as well. The latter is what happens in epubcheck. However there is no guarantee when Java runs the garbage collection, it could after hours. If epubcheck is integrated into another long running process, this can block EPUB file for quite a long time – during which it can not be deleted or overwritten.I have implemented a fix for this, storing the ZipFile in the state object and closing it once all checks have been performed. The ZipFile object is still required to be open for checking all the resources during the process so it cannot just be closed at the end of the
checkContainerStructure(···)method.A merge would be greatly appreciated.