Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HTML link element resources do not require fallbacks #1378

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

rdeltour
Copy link
Member

@rdeltour rdeltour commented Dec 1, 2022

EPUB 3.3 clarifies the situation of fallbacks for HTML link elements.

This commit:

  • fully suppresses error CSS-010 that was reported for foreign linked stylesheet resources (e.g. XPGT) with no manifest fallbacks
  • add a test to verify that other foreign linked resources do not require manifest fallbacks

Fix #1247

EPUB 3.3 clarifies the situation of fallbacks for HTML `link` elements.

This commit:
- fully suppresses error CSS-010 that was reported for foreign linked
  stylesheet resources (e.g. XPGT) with no manifest fallbacks
- add a test to verify that other foreign linked resources do not
  require manifest fallbacks

Fix #1247
@rdeltour rdeltour added this to the v5.0.0-beta milestone Dec 1, 2022
@rdeltour rdeltour requested a review from mattgarrish December 1, 2022 14:46
@rdeltour rdeltour self-assigned this Dec 1, 2022
Base automatically changed from feat/remove-pagelist-order-check to release/v5.0.0 December 1, 2022 22:08
@rdeltour rdeltour merged commit 168168a into release/v5.0.0 Dec 1, 2022
@rdeltour rdeltour deleted the feat/html-link-fallbacks branch December 1, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants