Skip to content

feat: #407 add support for sh:TripleTerm to sh:nodeKind and allow lists #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

bergos
Copy link
Contributor

@bergos bergos commented Jun 22, 2025

@bergos bergos marked this pull request as ready for review June 22, 2025 20:23
Copy link
Contributor

@HolgerKnublauch HolgerKnublauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to have sh:TripleTerm added, but I really don't think we should support rdf:Lists here as values. The common combinations are already covered with sh:BlankNodeOrIRI etc, and the use case for a combination of TripleTerm with others is very very rare. And in those corner cases, people can already use sh:or. But introducing list syntax here is yet another option that then needs to be supported by editing tools and any algorithm that walks shape structures, for example to determine whether a property is literal-typed. There is a lot of flow-on cost from such seemingly little tweaks to the spec.

@afs
Copy link
Contributor

afs commented Jun 23, 2025

Symmetry suggests that sh:BlankNodeOrIRIOrLiteral is now needed.

I think the use of a list makes sense and sh:x_Or_y can be redefined as equivalent to a list form so that tools need only support one form with a small amount of compatibility code when reading "sh:nodeKind".

@bergos
Copy link
Contributor Author

bergos commented Jun 24, 2025

I also see pros and cons:

Cons:

  • Adds complexity

Pros:

  • Consistency and the lack of symmetry if we stick to the old structure
  • Lists are easier to handle in node expressions

I favor making this change mainly because of the last point about node expressions.

@HolgerKnublauch
Copy link
Contributor

I am not blocking this but I think at we should deprecate the OR variations when the lists get allowed.

Best to be put on the agenda for the next meeting.

@afs
Copy link
Contributor

afs commented Jun 24, 2025

  • Lists are easier to handle in node expressions

Could you explain that please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for sh:TripleTerm to sh:nodeKind and allow lists
3 participants