Skip to content

Add a non-normative example for each Command #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2025
Merged

Add a non-normative example for each Command #93

merged 3 commits into from
Sep 4, 2025

Conversation

@jugglinmike
Copy link
Contributor

@jugglinmike jugglinmike commented Aug 21, 2025 •
edited by pr-preview bot
Loading

Resolves gh-87

Preview | Diff

@jugglinmike jugglinmike requested a review from ChrisC August 21, 2025 03:11
@jugglinmike
Extend example for "pressKeys"
d6ff361 
Based on implementer feedback, demonstrate the behavior of modifier
keys.
@jugglinmike
Add styling for the "kbd" HTML element
9c4810d
@jugglinmike
Copy link
Contributor Author

Thanks for the review, @ChrisC! We received some implementer feedback on a private channel: to extend the example for the pressKeys user intent with a modifier key. I've done that (and gussied up the visual presentation of keyboard keys a bit), so would you mind taking another look?

@jugglinmike jugglinmike requested a review from ChrisC August 28, 2025 14:03
@jugglinmike jugglinmike merged commit 3e15ec4 into main Sep 4, 2025
4 checks passed
@jugglinmike jugglinmike deleted the gh-87-add-command-examples branch September 4, 2025 14:38
@jugglinmike
Copy link
Contributor Author

Thanks!

github-actions bot added a commit that referenced this pull request Sep 4, 2025
@jugglinmike @github-actions
Add a non-normative example for each Command (#93)
4e2ff93 
SHA: 3e15ec4
Reason: push, by jugglinmike

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisC ChrisC ChrisC approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add one example for each command

3 participants

@jugglinmike @ChrisC