[accname] Do “AriaLabel” substep before “Embedded Control” substep #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reorders the “AriaLabel” substep in the set of steps in the accname Computation algorithm such that it occurs before the “Embedded Control” substep, rather than after that step. Otherwise, without this change, the spec as written doesn’t match the behavior as implemented in existing UAs, nor the corresponding requirements at https://w3c.github.io/html-aam/#accname-computation in the HTML-AAM spec: > If the [embedded-control] element has an aria-label or an > aria-labelledby attribute the accessible name is to be calculated > using the algorithm defined in Accessible Name and Description: > Computation and API Mappings. (Which is the first step in accname computation for each control) Also, without this change, the spec doesn’t match the expectations in http://wpt.fyi/results/accname/name/comp_label.html for the “input with label for association is superceded by aria-label” subtest.
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi, this seems like a significant spec change, which would break the following if the order was changed like this where aria-label was processed before the embedded control. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reorders the “AriaLabel” substep in the set of steps in the accname Computation algorithm such that it occurs before the “Embedded Control” substep, rather than after that step.
Otherwise, without this change, the spec as written doesn’t match the behavior as implemented in existing UAs, nor the corresponding requirements at https://w3c.github.io/html-aam/#accname-computation in the HTML-AAM spec:
(Which is the first step in accname computation for each control)
Also, without this change, the spec doesn’t match the expectations in http://wpt.fyi/results/accname/name/comp_label.html for the “input with label for association is superceded by aria-label” subtest.
Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.