Update: account for common labeledby spelling variant for aria-labell… #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edby Updates the existing note and adds new ua and author requirements for instances of aria-labelledby and aria-labeledby
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pkra
approved these changes
Nov 11, 2024
MelSumner
approved these changes
Nov 14, 2024
cookiecrook
reviewed
Nov 15, 2024
Co-authored-by: James Craig <[email protected]>
cookiecrook
requested changes
Dec 19, 2024
Co-authored-by: James Craig <[email protected]>
scottaohara
commented
Dec 19, 2024
Co-authored-by: James Craig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the existing note and adds new ua and author requirements for instances of aria-labelledby and aria-labeledby
Closes #2093
i did not put this content into the accounting for author errors section, because it just fit a lot better in the aria-labelledby section. so if that's not the way we want to go about this update, then i'd appreciate help in rewording / moving the content to that section, as i was just not finding the words/logical placement for it there.
Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.
Preview | Diff