Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New work item: crate r2c2_iri #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

New work item: crate r2c2_iri #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/CODEOWNER
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,8 @@
# Owners of the /dummy work-item
/dummy @pchampin @Tpt # ...

# Owners of the /iri work-item
/iri @pchampin

# Owners of another work item
# ...
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

members = [
"dummy",
"iri",
]
resolver = "3"

Expand Down
14 changes: 14 additions & 0 deletions iri/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
[package]
name = "r2c2_iri"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it seems most crate are using - instead of _ nowdays hence r2c2-iri

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at crates.io, it does not look like one is largely dominating the other...
I personally prefer the underscore (_) to keep the name of the crate consistent with how it is named in code.

But I won't die on that hill.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this seems to be unclear. My bad. I tend to prefer - for consistency with the keys in Cargo.toml I won't die on this hill either, let's choose something and stick with it.

version.workspace = true
authors.workspace = true
edition.workspace = true
repository.workspace = true
readme.workspace = true
license-file.workspace = true
keywords.workspace = true

[dependencies]

[lints]
workspace = true
4 changes: 4 additions & 0 deletions iri/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
//! TODO: define types and traits for handling IRIs.

#[cfg(test)]
mod tests {}