T8120: add support for per CPU architecture serial interface name#1128
Merged
sever-sever merged 4 commits intovyos:currentfrom Mar 2, 2026
Merged
T8120: add support for per CPU architecture serial interface name#1128sever-sever merged 4 commits intovyos:currentfrom
sever-sever merged 4 commits intovyos:currentfrom
Conversation
x86_64 and arm64 both use a different serial interface during Linux Kernel boot. Define either ttyS0 or ttyAMA0 per CPU architecture. This could be further overwritten by individual flavors.
When building an ISO image the files which are probed for no longer exist. This means it makes no sense to longer carry an unused hook.
|
👍 |
This file is only needed to support upgrades from the legacy image management tools. Example would be an upgrade from VyOS 1.3.8 -> 1.5 (which is officially unsupported, but we always try our best). This is also the reason why we can leave the ttyS0 console in this file - there was no ARM64 image for VyOS 1.3!
dmbaturin
approved these changes
Mar 1, 2026
Member
dmbaturin
left a comment
dmbaturin
left a comment
There was a problem hiding this comment.
I find the need to have console workarounds for different architectures annoying but that is the nature of the problem and we have to do something about it, one way or another.
I see no issues with the logic here.
sever-sever
approved these changes
Mar 2, 2026
Member
sever-sever
left a comment
sever-sever
left a comment
There was a problem hiding this comment.
Use the different Serial console depending on the CPU arch.
vyosbot
added
mirror-initiated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
x86_64 and arm64 both use a different serial interface during Linux Kernel boot. Define either ttyS0 or ttyAMA0 per CPU architecture. This could be further overwritten by individual flavors.
Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
VyOS smoketest infrastructure passed
make test-interfacesmake test-no-interfaces-no-vppmake testcChecklist: