Skip to content

Conversation

@sever-sever
Copy link
Member

@sever-sever sever-sever commented Nov 14, 2025

Change summary

Add support for the iavf driver (virtual function)

set vpp settings interface eth1 driver dpdk 
set vpp settings interfaces allow-unsupported-nics

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

👍
No issues in PR Title / Commit Title

@sever-sever sever-sever marked this pull request as draft November 18, 2025 14:20
@sever-sever
Copy link
Member Author

This driver has not been validated by our team

@sever-sever sever-sever marked this pull request as ready for review November 19, 2025 18:54
Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add support for community tested only VPP drivers - but officially unsupported by VyOS

driver: str = get_eth_driver(iface_name)

if driver_type == 'dpdk':
if driver in drivers_dpdk:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Driver iavf would not pass this check because it is not in drivers_dpdk. You should add it to drivers_dpdk list too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done some refactoring of my PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the iavf driver (Intel Adaptive Virtual Function) in VPP, introducing a community driver mechanism that allows the use of drivers not officially tested by VyOS with explicit opt-in through a configuration flag.

Key Changes:

  • Added iavf to the list of community-supported DPDK drivers with warning mechanism
  • Introduced allow-unsupported-nics configuration option to enable community drivers
  • Enhanced driver verification logic to distinguish between officially supported and community drivers

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
python/vyos/vpp/config_verify.py Adds community_drivers_dpdk list and modifies verify_dev_driver() to return True for community drivers with warning
src/conf_mode/vpp.py Imports community_drivers_dpdk and adds verification check requiring allow-unsupported-nics for community drivers
interface-definitions/vpp.xml.in Adds new interfaces settings node with allow-unsupported-nics configuration option

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Add support the iavf driver (virtual function)
@github-actions
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests VPP 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests ❌ failed
  • Config tests VPP 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants