Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove superflous WriteHeader call from buffer tests #246

Merged

Conversation

adamvduke
Copy link
Contributor

When running the tests for the buffer package with the -v flag, there is a log message that the call to WriteHeader from the TestBuffer_GRPC_OKResponse test is superfluous.

Before:

$ go test -v ./buffer -count=1 -run TestBuffer_GRPC_OKResponse
=== RUN   TestBuffer_GRPC_OKResponse
2024/12/16 11:55:54 http: superfluous response.WriteHeader call from github.com/vulcand/oxy/v2/buffer.TestBuffer_GRPC_OKResponse.func1 (buffer_test.go:420)
--- PASS: TestBuffer_GRPC_OKResponse (0.00s)
PASS
ok  	github.com/vulcand/oxy/v2/buffer	0.608s

After:

$ go test -v ./buffer -count=1 -run TestBuffer_GRPC_OKResponse
=== RUN   TestBuffer_GRPC_OKResponse
--- PASS: TestBuffer_GRPC_OKResponse (0.00s)
PASS
ok  	github.com/vulcand/oxy/v2/buffer	0.599s

@ldez ldez changed the title remove superflous WriteHeader call from buffer tests tests: remove superflous WriteHeader call from buffer tests Dec 16, 2024
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit c006fc1 into vulcand:master Dec 16, 2024
5 checks passed
@adamvduke adamvduke deleted the adamvduke/remove-superfluous-write-header branch December 16, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants