Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add browser tests with *.browser.test.ts files #4440

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

OrbisK
Copy link
Collaborator

@OrbisK OrbisK commented Dec 28, 2024

related to #3792

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

This pr adds an optional vitest browser test to the *.browser.test.ts files. This allows us to test demo pages and functions that require a browser (such as useAnimate).

Additional context

I've no clue how to add deps to the catalog instead the root package.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 28, 2024
@OrbisK OrbisK requested a review from antfu December 30, 2024 19:39
@@ -23,8 +23,10 @@
"release": "bumpp --execute=\"npm run release:prepare\" --all",
"release:prepare": "npm run build:types && npm run update",
"size": "tsx scripts/export-size.ts",
"test": "vitest",
"test": "nr test:unit",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kept this as unit test for 'backwards comparability'.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 31, 2024
@antfu antfu merged commit 566a4ff into vueuse:main Dec 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants