-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(useElementHover): returns correctly hover state when element is removed #4410
base: main
Are you sure you want to change the base?
Conversation
Maybe we could refactor this out with vueuse/packages/core/useActiveElement/index.ts Lines 60 to 74 in 9399ba1
to have |
Sure, do you mean make a new composition function first? I thought we were not accepting new features at the moment. |
Yeah. This is fine as it doesn't increase the maintenance surface |
2885f30
to
b4667c0
Compare
…formance overhead
make the two composables internally reuse the onElementRemoval function, add optional parameters `flush` to onElementRemoval
17ff28d
to
abb12ec
Compare
I've done add a new composition function |
Before submitting the PR, please make sure you do the following
fixes #123
).Description
closes #4379 , use mutationobserver to observe whether the element are removed.
By adding a new argument to avoid general performance overhead.
Additional context