Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useElementHover): returns correctly hover state when element is removed #4410

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ben-lau
Copy link
Contributor

@ben-lau ben-lau commented Dec 19, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

closes #4379 , use mutationobserver to observe whether the element are removed.
By adding a new argument to avoid general performance overhead.

Additional context

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 19, 2024
@antfu
Copy link
Member

antfu commented Dec 20, 2024

Maybe we could refactor this out with

if (triggerOnRemoval) {
useMutationObserver(document as any, (mutations) => {
mutations.filter(m => m.removedNodes.length)
.map(n => Array.from(n.removedNodes))
.flat()
.forEach((node) => {
if (node === activeElement.value)
trigger()
})
}, {
childList: true,
subtree: true,
})
}

to have onElementRemoval composable to be reused for these two composables

@ben-lau
Copy link
Contributor Author

ben-lau commented Dec 20, 2024

Maybe we could refactor this out with

if (triggerOnRemoval) {
useMutationObserver(document as any, (mutations) => {
mutations.filter(m => m.removedNodes.length)
.map(n => Array.from(n.removedNodes))
.flat()
.forEach((node) => {
if (node === activeElement.value)
trigger()
})
}, {
childList: true,
subtree: true,
})
}

to have onElementRemoval composable to be reused for these two composables

Sure, do you mean make a new composition function first? I thought we were not accepting new features at the moment.

@antfu
Copy link
Member

antfu commented Dec 22, 2024

Yeah. This is fine as it doesn't increase the maintenance surface

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 24, 2024
@ben-lau
Copy link
Contributor Author

ben-lau commented Dec 24, 2024

Yeah. This is fine as it doesn't increase the maintenance surface

I've done add a new composition function onElementRemoval, and used it inside useActiveElement, useElementHover. You may review the code, I see there is something wrong in lint ci process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

BUG | useElementHover | Value remains true after target is unmounted
2 participants