Skip to content

feat(VTabs): add inset prop #22221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Parent: fix(VBtn): stacked button couldn't be of type block
wants to merge 1 commit into
base: dev
Choose a base branch
from
+62 −1
Draft

feat(VTabs): add inset prop #22221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions packages/vuetify/src/components/VTabs/VTabs.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,59 @@
.v-tab:last-child
margin-inline-end: 0

.v-tabs--inset
--v-tabs-inset-radius: 18px
--v-tabs-inset-padding: 4px

background: rgba(var(--v-theme-on-surface), 0.06)
box-shadow: inset 0 0 0 2px rgba(var(--v-border-color), var(--v-border-opacity))
max-width: max-content
border-radius: calc(var(--v-tabs-inset-radius) + var(--v-tabs-inset-padding))

.v-tab
min-width: 0
margin: var(--v-tabs-inset-padding)
transition-property: box-shadow, transform, opacity, background, color
border-radius: var(--v-tabs-inset-radius)

&:focus-visible
outline: 2px solid rgb(var(--v-border-color))
outline-offset: 2px

&:after
opacity: 0

.v-tab__slider
inset: 0
border-radius: var(--v-tabs-inset-radius)
z-index: -1
width: auto

.v-tab--selected
/* TODO: set text-* class */
color: rgb(var(--v-theme-surface))

&.v-tabs--horizontal
height: calc(var(--v-tabs-height) + var(--v-tabs-inset-padding) * 2)
--v-tabs-inset-tab-radius: calc(var(--v-tabs-outer-radius) - var(--v-tabs-inset-padding) + 4px)

&.v-tabs--horizontal .v-tab__slider
height: auto

&.v-tabs--vertical .v-tab__slider
height: calc(100% - 2 * var(--v-slider-padding))

.v-slide-group__content
padding-inline: var(--v-slider-padding)

.v-btn__overlay
display: none

&.v-tabs--vertical .v-tab
grid-template-columns: max-content 1fr max-content
> .v-btn__content
justify-content: start

@media #{map.get(settings.$display-breakpoints, 'md-and-down')}
.v-tabs.v-slide-group--is-overflowing.v-slide-group--horizontal:not(.v-slide-group--has-affixes)
.v-tab:first-child
Expand Down
10 changes: 9 additions & 1 deletion packages/vuetify/src/components/VTabs/VTabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ export const makeVTabsProps = propsFactory({
default: undefined,
},
hideSlider: Boolean,
inset: Boolean,
insetPadding: [String, Number],
insetRadius: [String, Number],
sliderColor: String,

...pick(makeVTabProps(), ['spaced']),
Expand Down Expand Up @@ -130,14 +133,19 @@ export const VTabs = genericComponent<new <T = TabItem>(
{
'v-tabs--fixed-tabs': props.fixedTabs,
'v-tabs--grow': props.grow,
'v-tabs--inset': props.inset,
'v-tabs--stacked': props.stacked,
},
densityClasses.value,
backgroundColorClasses.value,
props.class,
]}
style={[
{ '--v-tabs-height': convertToUnit(props.height) },
{
'--v-tabs-height': convertToUnit(props.height),
'--v-tabs-inset-padding': props.inset ? convertToUnit(props.insetPadding) : undefined,
'--v-tabs-inset-radius': props.inset ? convertToUnit(props.insetRadius) : undefined,
},
backgroundColorStyles.value,
props.style,
]}
Expand Down