-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
fix(VField): remove overlay for clearable button, if field is not active #20534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VField): remove overlay for clearable button, if field is not active #20534
Conversation
18e9408
to
8775938
Compare
@johnleider Maybe the changes in the first test arn't needed, but screen.getByCss didn't work in my environment. The changes in the second text neede, because the clearable icon is only redered if the field is active. without these change the test fail. (As I remember correctly) |
3853001
to
d6fdc1b
Compare
…on,-if-field-is-not-active
…on,-if-field-is-not-active
…on,-if-field-is-not-active
…on,-if-field-is-not-active
…on,-if-field-is-not-active
Is there anything that I have todo, that this PR can be merged 🤔 |
…on,-if-field-is-not-active
…on,-if-field-is-not-active
…on,-if-field-is-not-active
@johnleider thanks for the review. Better now? |
Looks great. Will have to wait for this though. Expand animations with margin/padding always have a jump whenever the element enters or leaves. Overall, you've done as much as the framework will allow. |
…lay-for-clearable--button,-if-field-is-not-active
…on,-if-field-is-not-active
…on,-if-field-is-not-active
…on,-if-field-is-not-active
…on,-if-field-is-not-active
…on,-if-field-is-not-active
Looks like this PR will never be merged and is obsolete because of #21567. So I will close it |
Hide the coverlay of clearable if a input field id not hovered and not focused
Description
Fixes #20375
Markup: