Skip to content

Conversation

mueller-jens
Copy link
Contributor

@mueller-jens mueller-jens commented Sep 29, 2024

Hide the coverlay of clearable if a input field id not hovered and not focused

Description

Fixes #20375

Markup:

@mueller-jens mueller-jens changed the title Feature/remove overlay for clearable button, if field is not active Feature(VField): remove overlay for clearable button, if field is not active Sep 29, 2024
@mueller-jens mueller-jens changed the title Feature(VField): remove overlay for clearable button, if field is not active fix(VField): remove overlay for clearable button, if field is not active Sep 29, 2024
@mueller-jens mueller-jens force-pushed the feature/Remove-overlay-for-clearable--button,-if-field-is-not-active branch 2 times, most recently from 18e9408 to 8775938 Compare October 5, 2024 13:16
@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected C: VField labels Oct 28, 2024
@johnleider
Copy link
Member

I believe this was made to always render because it caused a layout jump when the clear element was rendered. Also, are these changes necessary?

image

@mueller-jens
Copy link
Contributor Author

@johnleider Maybe the changes in the first test arn't needed, but screen.getByCss didn't work in my environment. The changes in the second text neede, because the clearable icon is only redered if the field is active. without these change the test fail. (As I remember correctly)

@mueller-jens mueller-jens force-pushed the feature/Remove-overlay-for-clearable--button,-if-field-is-not-active branch from 3853001 to d6fdc1b Compare February 2, 2025 18:57
@mueller-jens mueller-jens reopened this Feb 3, 2025
@johnleider johnleider self-requested a review February 27, 2025 21:51
@johnleider johnleider added this to the v3.7.x milestone Feb 27, 2025
@mueller-jens
Copy link
Contributor Author

Is there anything that I have todo, that this PR can be merged 🤔

@johnleider
Copy link
Member

Is there anything that I have todo, that this PR can be merged 🤔

The entry animation is lost doing it this way:
textfield

@mueller-jens
Copy link
Contributor Author

@johnleider thanks for the review. Better now?

@johnleider
Copy link
Member

Looks great. Will have to wait for this though. Expand animations with margin/padding always have a jump whenever the element enters or leaves. Overall, you've done as much as the framework will allow.

@johnleider johnleider added the S: on hold The issue is on hold until further notice label Mar 27, 2025
@johnleider johnleider modified the milestones: v3.7.x, v3.9.0 (Zealot) Mar 27, 2025
Jens Müller and others added 2 commits April 28, 2025 20:03
@mueller-jens
Copy link
Contributor Author

Looks like this PR will never be merged and is obsolete because of #21567. So I will close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C: VField S: on hold The issue is on hold until further notice T: bug Functionality that does not work as intended/expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature(VTextField) Remove overlay for clearable- button, if field is not active

3 participants