-
Notifications
You must be signed in to change notification settings - Fork 459
feat: tailwind 4 migration #3281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FRSgit
wants to merge
15
commits into
v2-develop
Choose a base branch
from
feat/tailwind-4-migration
base: v2-develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: changed paddings in sfselect * chore: adjusted padding left * chore: updated changelog * Update .changeset/fresh-emus-care.md Co-authored-by: Jakub Freisler <[email protected]> --------- Co-authored-by: Jakub Freisler <[email protected]>
* BREAKING CHANGE: remove flex classes form wrapper slot in list item * fix: lint fixes * fix: lint fixes
#3008) BREAKING CHANGE: remove deprecated useTrapFocus arrowKeysOn option
🦋 Changeset detectedLatest commit: 4aff1ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
looking forward to use it with tailwind v4 |
1 task
# Conflicts: # apps/docs/components/content/_hooks/useTrapFocus.md # packages/sfui/frameworks/react/components/SfListItem/SfListItem.tsx # packages/sfui/frameworks/vue/components/SfListItem/SfListItem.vue # packages/sfui/frameworks/vue/composables/useTrapFocus/useTrapFocus.ts # packages/tests/components/SfButton/SfButton.cy.tsx
# Conflicts: # apps/docs/components/components/content/ColorPaletteBlock.vue # apps/preview/next/package.json # apps/preview/next/pages/examples/SfAccordionItem.tsx # apps/preview/next/pages/showcases/ProductCard/Details.tsx # apps/preview/next/pages/showcases/ProductCard/ProductCardHorizontal.tsx # apps/preview/next/pages/showcases/QuantitySelector/OutOfStock.tsx # apps/preview/next/pages/showcases/QuantitySelector/QuantitySelector.tsx # apps/preview/next/pages/showcases/QuantitySelector/Rounded.tsx # apps/preview/nuxt/pages/examples/SfAccordionItem.vue # apps/test/react/package.json # apps/test/vue/package.json # package.json # packages/config/tailwind/index.ts # packages/config/tailwind/package.json # packages/sfui/frameworks/react/components/SfButton/SfButton.tsx # packages/sfui/frameworks/react/components/SfCheckbox/SfCheckbox.tsx # packages/sfui/frameworks/react/components/SfChip/SfChip.tsx # packages/sfui/frameworks/react/components/SfInput/SfInput.tsx # packages/sfui/frameworks/react/components/SfLink/SfLink.tsx # packages/sfui/frameworks/react/components/SfModal/SfModal.tsx # packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx # packages/sfui/frameworks/react/components/SfTextarea/SfTextarea.tsx # packages/sfui/frameworks/vue/components/SfAccordionItem/SfAccordionItem.vue # packages/sfui/frameworks/vue/components/SfButton/SfButton.vue # packages/sfui/frameworks/vue/components/SfCheckbox/SfCheckbox.vue # packages/sfui/frameworks/vue/components/SfChip/SfChip.vue # packages/sfui/frameworks/vue/components/SfInput/SfInput.vue # packages/sfui/frameworks/vue/components/SfLink/SfLink.vue # packages/sfui/frameworks/vue/components/SfModal/SfModal.vue # packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue # packages/sfui/frameworks/vue/components/SfTextarea/SfTextarea.vue # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #
Scope of work
https://tailwindcss.com/docs/upgrade-guide
To avoid some of the breaking changes introduced by Tailwind 4 and to keep sensible defaults we want to give to out users, SFUI Tailwind configuration:
cursor: pointer
style for button elements.Screenshots of visual changes
Checklist