feat(core): optimize default value handling for options.locales#1676
Open
pengzhanbo wants to merge 4 commits intovuepress:mainfrom
Open
feat(core): optimize default value handling for options.locales#1676pengzhanbo wants to merge 4 commits intovuepress:mainfrom
options.locales#1676pengzhanbo wants to merge 4 commits intovuepress:mainfrom
Conversation
Pull Request Test Coverage Report for Build 21939083597Details
💛 - Coveralls |
options.locales
Member
|
I think this is not what I mean. In short, a / and /404.html shall exist. These belong to locale /, then locale / MUST exist. A plugin can also choose to generate a The or should ensure to generate a locale / |
Mister-Hope
requested changes
Feb 11, 2026
Member
Mister-Hope
left a comment
There was a problem hiding this comment.
I think this is not what I mean.
In short, a / and /404.html shall exist. These belong to locale /, then locale / MUST exist.
A plugin can also choose to generate a /plugin.html.
The or should ensure to generate a locale /
Member
Author
|
Because the time interval is a bit long, what was the solution we discussed back then? |
Member
|
Locales object and its / key must exist, with a lang inferred from root lang if absent |
Mister-Hope
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
close #123).What is the purpose of this pull request?
Description
Screenshots
Before
After